voxmedia / github-action-slack-notify-build

Report GitHub Actions build status on Slack
Other
252 stars 131 forks source link

bump Node.js 12 actions to 16 #69

Closed klamas1 closed 1 year ago

klamas1 commented 1 year ago

Purpose

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: voxmedia/github-action-slack-notify-build

Important Changes

runs: using: 'node16'

aariacarterweir commented 1 year ago

yo pls can we get this merged? if not, @klamas1 would you be willing to fork?

klamas1 commented 1 year ago

"1 workflow awaiting approval", waiting for one more

john-doherty commented 1 year ago

Is it possible to use this PR as a GitHub action?

aariacarterweir commented 1 year ago

Yeah curious if it is too?

On Mon, 17 Oct 2022 at 8:54 pm, John Doherty @.***> wrote:

Is it possible to use this PR as a GitHub action?

— Reply to this email directly, view it on GitHub https://github.com/voxmedia/github-action-slack-notify-build/pull/69#issuecomment-1280671319, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHKFEKVEN6GOPCN3F3ILATWDUV5LANCNFSM6AAAAAARC3PVTM . You are receiving this because you commented.Message ID: @.***>

-- Sent from Gmail Mobile

klamas1 commented 1 year ago

Write in the issue https://github.com/voxmedia/github-action-slack-notify-build/issues/68

clemblanco commented 1 year ago

Bump up

aariacarterweir commented 1 year ago

Bump again

aariacarterweir commented 1 year ago

Are we able to get this merged please?

AdmirHad commented 1 year ago

Bumping the PR

lfg-will commented 1 year ago

This pull request has been approved for over a month now. Can we at least get a reason why? Otherwise I feel like I will need to migrate to an actively-maintained fork.

klamas1 commented 1 year ago

Enough Approves, We Need a Merge

"Only those with write access to this repository can merge pull requests."

aariacarterweir commented 1 year ago

Anyone know a good fork we can migrate to? This repo has clearly been abandoned.

tallmanbrew commented 1 year ago

Doesn't seem that the 3 people that have ever merged PR's work for voxmedia any longer.

klamas1 commented 1 year ago

There doesn't seem to be any updates to this repo. if you just want to use the notification action you can fork my version or use my repo directly uses: klamas1/github-action-slack-notify-build@v3

sstopkin commented 1 year ago

@ealcantara22 @sixfoot6 @okor @maria-mata @nicolezhu Is there anybody from voxmedia, who able to just click the MERGE button? Thanks!

ebinmore commented 1 year ago

This repo has been abandon for different tooling internally. I will merge this PR. Moving forward, you should seriously consider maintaining your own fork or use someone else's like https://github.com/voxmedia/github-action-slack-notify-build/pull/69#issuecomment-1330115044.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.6.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: