search

voxpelli / node-connect-pg-simple

A simple, minimal PostgreSQL session store for Express
https://www.npmjs.com/package/connect-pg-simple
MIT License
233 stars 74 forks source link

Change `pg` to a peer dependency #227

Closed thernstig closed 1 year ago

thernstig commented 2 years ago

Currenly pg is configured as a dependency of this project:

https://github.com/voxpelli/node-connect-pg-simple/blob/fdfcda883f0f730a3ee8e56d6e2d717e442d2f7d/package.json#L16-L19

Would it not be more correct to install this as a peerDependency? With npm 7 peer dependencies are also installed by default.

voxpelli commented 2 years ago

I don't think it would add much to do that change and its not strictly more correct. Only slight benefit would be to be able to indicate unsupported versions of pg 🤔

I'll think about it + lets other weigh in on it.

voxpelli commented 1 year ago

I currently see no need for this change and no one else has weighed in over a year.

I'm still open to having a discussion of some feel strongly about this in either direction.