search

voxpupuli-archive / puppet-bacula

Bacula module to manage all components of bacula
https://forge.puppet.com/puppet/bacula
Apache License 2.0
38 stars 52 forks source link

clients argument missing in bacula::director call #17

Closed msurdi closed 11 years ago

msurdi commented 11 years ago

I couldn't make it generate the clients files, so after some debugging I found that the class bacula::director was never getting the $clients variable populated. I also fixed the docs for the $clients hash.

msurdi commented 11 years ago

Just added to my master branch support for custom client_config template, might be worth to add it too.

Thanks!!

dblessing commented 11 years ago

msurdi: This is causing me some problems, too. I'd definitely like it to be integrated quickly. To ensure they can merge once they get to it can you create a bug at http://projects.puppetlabs.com/projects/modules and be sure to sign the contributor's agreement after signing into your account.

msurdi commented 11 years ago

Done! https://projects.puppetlabs.com/issues/17254

dblessing commented 11 years ago

Great! Thanks msurdi. I hope someone gets these requests merged quickly!

ccaum commented 11 years ago

@justinellison Can you review and merge if it work?

justinellison commented 11 years ago

@ccaum we had a couple of must-do-before holiday projects jump in front of our bacula project. We should get a chance to review and test this in the next week or two. I know @bke-drewb had verified the bug, and the fix looks pretty simple -- I'd just like to test it before merging.

webratz commented 11 years ago

any news regarding the merge?

justinellison commented 11 years ago

I apologize for the delays. I really wanted to get this tested, but our project has been de-scoped. @webratz @msurdi the code looks sound, so I just went ahead and merged this into master, can you please let me know if this breaks anything?

webratz commented 11 years ago

first very short test looks fine