voxpupuli-archive / puppet-bacula

Bacula module to manage all components of bacula
https://forge.puppet.com/puppet/bacula
Apache License 2.0
38 stars 52 forks source link

Pull postgresql redhat #29

Closed Spenser309 closed 9 years ago

Spenser309 commented 10 years ago

This patch series adds postgresql support and support for RHEL 6 based distros with bacula 5.0.x .

This fixes issue https://github.com/puppetlabs/puppetlabs-bacula/issues/23 .

andrewspiers commented 10 years ago

Should we add a dependency in the Vagrantfile to the puppet labs forge module for postgres?

puppetcla commented 9 years ago

Waiting for CLA signature by @Spenser309

@Spenser309 - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

puppetcla commented 9 years ago

CLA signed by all contributors.

pemer commented 9 years ago

Dear Spenser309,

The default port configuration manifests/config.pp in your patch does not work. At the time the default your set, you didn't defined a db_backend, so the result can be by postgresql 3306.

regards Patrick

tphoney commented 9 years ago

Could you please have a look at #31 and see if that PR makes more sense ?

tphoney commented 9 years ago

Thanks for the work you have put in to this pull request. Based on what @pemer said and the lack of activity, this pull request is being closed. If you want to re-submit this pr with the necessary changes, we will look at the new pull request. It may be worth looking into #31