voxpupuli-archive / puppet-bacula

Bacula module to manage all components of bacula
https://forge.puppet.com/puppet/bacula
Apache License 2.0
38 stars 52 forks source link

(#11296) (#11297) Support Multiple Database backend configurations #3

Closed ccaum closed 12 years ago

ccaum commented 12 years ago

Previous to this pull request, only the sqlite database backend was supported. This commit supports any number of database backends by utilizing the bacula syntax in the bacula.dir configuration file.

his commit also supports the management of the mysql database backend. If manage_db is true and the db_backend is 'mysql' as well as either is_director or is_storage is true, the bacula module will create the mysql database, and grant privileges to the db_user. Likewise for if the db_backend is 'sqlite'.

Further, if manage_db_tables is true (is true by default) the bacula module will create the database tables for the db_backend when the bacula server packages are installed.

jeffmccune commented 12 years ago

Two nitpick comments. First, the document headers aren't RDoc. I'd like to see this addressed and make sure it works with puppet doc. Second, I'm not a fan of lines > 80 characters. I had to do a lot of horizontal scrolling reading the pull request. =)