jeffmccune
commented
12 years ago There was some confusion from my last nitpick comment about line lengths. I'm just adding what we talked about in person for the rest of the team.
For git commits, it's not a huge deal but typically the first line should be less than 50 characters. This is definitely a soft limit but it helps for things like Mike's changelog rake tasks.
All of the other paragraphs in the commit message can be standard conventions. Typically < 80 chracters. In vim, gwap will re-flow a paragraph automatically for you which may help frustration levels.
Finally, my real comment was about the line lengths of the code. There's still some in this pull request that are > 120 characters. If possible, please try to keep code line lengths below 80 as well, but again this is my preference and by no means a requirement or anything.
It helps for those of us with 13" laptop displays.
Other than these comments the code looks fine.
Previously, creating new clients to be backed up required modifying the bacula-dir.conf.erb template.
This adds a new class parameter,
clientsthat accepts a hash. The key of the hash is the FQDN of the host while the value is a hash of parameters. In addition to the class parameter, users can specify top scope (ENC) parameters that will generate clients. The parameter to create in the ENC is of the format bacula_client_node.domain.com. The value of the parameter is in the format resourceparam=value,resourceparam=value.So to create a client mybackup.mydomain.com with to backup with the fileset Basic:noHome on the Weekly schedule, the name of the ENC parameter is
bacula_client_mybackup.mydomain.comwith a value offileset=Basic:noHome,schedule=Weekly. Using the clients class parameter, the value of $clients would be $clients = { 'mybackup.mydomain.com' => { 'fileset' => 'Basic:noHome', 'schedule' => 'Weekly', }