voxpupuli-archive / puppet-bacula

Bacula module to manage all components of bacula
https://forge.puppet.com/puppet/bacula
Apache License 2.0
38 stars 48 forks source link

More parameters to make bacula::cient working on Solaris #7

Closed pesimon closed 9 years ago

pesimon commented 12 years ago

Please have a look, to the following changes

ccaum commented 12 years ago

This is pretty awesome. Thanks. Can you update the parameters list in the README and maybe add a section about how to manage it in Solaris?

pesimon commented 12 years ago

Sure. Do you think it'd make sense to introduce top scope equivalents to all new bacula::client parameters?

ccaum commented 12 years ago

@pesimon Sorry I've been lagging on this. It's been fairly busy around here. Yes, I think all parameters should have top scope equivalents. My goal is to keep this module configurable from the top scop/ENC level as well as class parameters. I'm also trying to stick to having a single point of entry, being the bacula class. This makes delegation to sub-classes easier and makes things like validation easier.

ccaum commented 12 years ago

@justinellison Can you take a look at this and merge if it works?

justinellison commented 12 years ago

We've phased out all of our Solaris hosts, so I can't test for the positive. However, so long as it doesn't break the Linux path, I'll take @pesimon word for it that it does work on Solaris. Give us a week or two to get the bandwidth to get our bacula project moving again so we can test it, then I'll merge it.