Open pfrayer opened 2 months ago
@pfrayer thanks for the PR! Can you check the used email address in the commit? It isn't associated with your github account.
@bastelfreak my bad, fixed
I think this is also a breaking change, because now you would have to make sure that you have a read user created. If someone simply updates the container with an already running configuration, this breaks.
You are right, as-is this is a breaking change.
I will make it more conditional to set the read-database.conf
file only if PUPPETDB_READ_USER
and PUPPETDB_READ_PASSWORD
are given.
okay, so i should wait with the merge? or will you do another PR? ... just doing a v1.6.0 to preserve the present state and then i wanted to merge this one an do a 2.0.0 release. if if we could have a condition, that would be greate
Yes wait before merging this PR, I'll update it with the condition stuff.
Sorry for the delay I was in holiday (so not so sorry)
I added the conditional logic about this read-database config. The idea is:
read-database.conf
file at build timedocker-entrypoint.sh
)Please tell me if this logic is OK for you
ah dang it. ci fails because cannot access the secrets from a fork-pr. will investigate later...
PuppetDB supports a
[read-database]
settings: https://www.puppet.com/docs/puppetdb/8/configure.html#read-database-settings PuppetDB needs to have 2 database users: one with RW, one with ROIt's mentioned in #43
This PR adds a simple
read-database.conf
in/etc/puppetlabs/puppetdb/conf.d/
to use this feature. The default values for user comes from the official documentation: https://www.puppet.com/docs/puppetdb/8/configure_postgres.html