search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.54k stars 243 forks source link

Remove ruby warnings #286

Closed teoljungberg closed 8 years ago

teoljungberg commented 8 years ago

For the unused varaiables schema, data, and validator

iainbeeston commented 8 years ago

Hey @teoljungberg

This test is such a mess, isn't it? I'm not sure the original really explained the intent.

iainbeeston commented 8 years ago

I've tried to explain the intent inline.

I think your changes make both tests identical? And also I think it has lost the original intent of the tests

teoljungberg commented 8 years ago

@iainbeeston You are absolutely right.

In light of that, I think the only change needed here is to mark validator as an unused variable. I've updated the PR to reflect that. Am I correct to assume so?

iainbeeston commented 8 years ago

@teoljungberg Yes that's right. I'd be more than happy to merge that. I can't see the updated code though?

teoljungberg commented 8 years ago

@iainbeeston I took some time away from the computer during the holidays, sorry I haven't responded.

I've updated the PR now with the recent changes after our discussion. I've also squashed the commits.

RST-J commented 8 years ago

:+1: