search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.53k stars 242 forks source link

Tidy up tests #290

Closed iainbeeston closed 8 years ago

iainbeeston commented 8 years ago

I've tidied up a few things in the test directory that were annoying me:

  1. Made test classes consistently named FooTest (not TestFoo, FooTests or just Foo)
  2. Renamed test files to match the test class that they contain
  3. Moved test_helper.rb out of the /test directory and into /test/support
  4. Renamed any tests that had inaccurate, vague or misleading names
iainbeeston commented 8 years ago

Any thoughts on this? (My goal is to make it easier to know where to add new tests, by making the naming of existing ones more consistent)

iainbeeston commented 8 years ago

@RST-J do you think this is a good idea? Or can you suggest any changes?

RST-J commented 8 years ago

I'll have a look some time soon. I think this needs some time to think about. In general I like your idea and aim very much.

RST-J commented 8 years ago

Not sooo soon, but finally. I think it's fine. :+1: