search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.54k stars 243 forks source link

Moved Validator#absolutized_uri and RefAttribute's ref parsing into the URI module #345

Closed iainbeeston closed 8 years ago

iainbeeston commented 8 years ago

I just noticed that we have this URI processing method in Validator, and similar code in RefAttribute. I had thought we'd moved all of these into the URI module, but these must have been missed.

I've taken the opportunity to tidy them up slightly too.

One day we might be able to unify these methods

iainbeeston commented 8 years ago

@RST-J This PR also helps to move all URI parsing code into one place

iainbeeston commented 8 years ago

@RST-J I've corrected the issues you've mentioned, thanks for the feedback!