search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 242 forks source link

Add Ruby 2.4.0 support. #368

Closed marshall-lee closed 7 years ago

marshall-lee commented 7 years ago

Fixnum is deprecated in Ruby 2.4 so it should be replaced with Integer

lleger commented 7 years ago

Tried to upgrade an app to Ruby 2.4 today and got bit by this. Any idea when you might be able to get a 2.4-compatible version pushed out?

iainbeeston commented 7 years ago

It's the highest priority issue right now but unfortunately this PR needs some work before we can safely merge it. I can't give any timelines because it will depend on when myself of one of the other maintainers can spend some time on it. Sorry I can't be more precise but we are aware of the issue and are looking into it

iainbeeston commented 7 years ago

I've split this into two separate commits and merged manually (one to remove references to Fixnum and one to make error messages consistently refer to json-schema types rather than ruby types), and I have released these changes under json-schema 2.8.0

Thanks for your contributions @marshall-lee