search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 242 forks source link

Refactor common test suite #377

Closed iainbeeston closed 7 years ago

iainbeeston commented 7 years ago

This pull request contains a number of improvements to how we use the common test suite:

  1. Ignored tests from the common test suite are now stored in yaml file (rather than a large ruby hash)
  2. We no longer abort running the tests if the common test suite cannot be updated (ie. when there is no internet connection)
  3. Tests in the common test suite that are part of the core spec (ie. not optional) are now skipped rather than ignored
  4. It ignores a number of new failing tests in draft6

Please see the commit messages for more details of each change

iainbeeston commented 7 years ago

@RST-J Do you have time to code review this pull request? It should fix the failing tests in the common test suite and hopefully stop them failing unexpectedly in future

iainbeeston commented 7 years ago

@RST-J thanks!