voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 242 forks source link

Made sure we require timeout before using it #385

Closed iainbeeston closed 2 years ago

iainbeeston commented 7 years ago

If you run JSON::Validator.validate(metaschema, "http://a/%%30%30") then you'll see the error "uninitialized constant Timeout". This is happening because we reference Timeout in Validator without requiring it.

Interestingly I can't reproduce this error in the test suite because something else (probably webmock?) is already requiring timeout for us, and this error does not occur.

Fixes #384

iainbeeston commented 7 years ago

@RST-J Could I please get a review of this too?