search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 242 forks source link

Data that looks like a URI but is invalid should be treated as a string #386

Open iainbeeston opened 7 years ago

iainbeeston commented 7 years ago

There's a bug where if you pass a string as data and it looks like a URI, we try to parse it and load the data from that location. However, if parsing fails, we should give up trying to load remote data and treat the data as a string instead.

iainbeeston commented 7 years ago

@RST-J Could I please get a review of this too?

RST-J commented 7 years ago

Sorry, I'm currently not able to review. I have RL stuff to deal with.

⁣Bis neulich Jonas

Gesendet mit BlueMail ​

Am 5. Juli 2017, 19:36, um 19:36, Iain Beeston notifications@github.com schrieb:

@RST-J Could I please get a review of this too?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/ruby-json-schema/json-schema/pull/386#issuecomment-313173511

iainbeeston commented 7 years ago

@RST-J No problem, I understand completely (sorry for spamming you with requests!)

exterm commented 8 months ago

This seems like it is still a problem, @bastelfreak could you take a look?

ekohl commented 8 months ago

There's at least a merge conflict so it needs a rebase.