search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 242 forks source link

Always download the common test suite before running tests #387

Open iainbeeston opened 7 years ago

iainbeeston commented 7 years ago

In #377 I made it possible to run the tests without having internet access. But it seems that in the process I also disabled the code that downloads the common test suite when you first check out the codebase.

This changes the behaviour so that if you run the test suite and you have internet access the common test suite is automatically downloaded. If you don't have internet access it continues without it. To update the common test suite to the latest version, you now need to run the tests with the UPDATE_TEST_SUITE env var set.

iainbeeston commented 7 years ago

@RST-J Could I please get a quick review of this? It's a change to the test suite rather than user-facing code.

iainbeeston commented 7 years ago

Ok this isn't fixing an issue on travis as I first thought. It seems that by default travis performs a git submodule update after checkout, which is what we're doing here. However, it would be helpful if we did this automatically for contributors too