Always return duplicates from JSON::Util::URI.parse

voxpupuli / json-schema

Ruby JSON Schema Validator

MIT License

1.52k stars 241 forks source link

Always return duplicates from JSON::Util::URI.parse #442

Closed jhass closed 2 years ago

jhass commented 4 years ago

Some callsides seem to modify the returned URI instance, messing up the cache. This can lead to the wrong schema fragment being used when multiple schemas with overlapping fragment paths are loaded and validated against.

Unfortunately I didn't manage to construct an integrative test case and I'm not sure how much worth something would be that just checks this method is indeed returning duplicates in any case

pboling commented 3 years ago

https://github.com/ruby-json-schema/json-schema/issues/423#issuecomment-634811990

bastelfreak commented 2 years ago

Hi @jhass , thanks for bringing this up. The project was recently migrated to Vox Pupuli. Are you able to rebase and add a test now?

jhass commented 2 years ago

No, after two years I no longer have the original context.