search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 241 forks source link

Add Ruby 2.6/2.7 support #457

Closed bastelfreak closed 2 years ago

bastelfreak commented 2 years ago

This is a resubmission of https://github.com/voxpupuli/json-schema/pull/437

codecov[bot] commented 2 years ago

Codecov Report

Merging #457 (1fc6dfd) into master (279cea0) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 1fc6dfd differs from pull request most recent head bdea027. Consider uploading reports for the commit bdea027 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   89.75%   89.76%           
=======================================
  Files          74       74           
  Lines        1581     1563   -18     
=======================================
- Hits         1419     1403   -16     
+ Misses        162      160    -2
Impacted Files Coverage Δ
lib/json-schema/attributes/formats/ip.rb 95.45% <100.00%> (-0.20%) :arrow_down:
lib/json-schema/attributes/allof.rb 95.00% <0.00%> (-0.24%) :arrow_down:
lib/json-schema/attribute.rb 100.00% <0.00%> (ø)
lib/json-schema/util/uuid.rb 47.40% <0.00%> (ø)
lib/json-schema/attributes/not.rb 100.00% <0.00%> (ø)
lib/json-schema/attributes/type.rb 100.00% <0.00%> (ø)
lib/json-schema/attributes/anyof.rb 100.00% <0.00%> (ø)
lib/json-schema/attributes/oneof.rb 100.00% <0.00%> (ø)
lib/json-schema/validators/draft1.rb 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 279cea0...bdea027. Read the comment docs.

os6sense commented 2 years ago

Any plans to deal with the deprecation warnings that are raised when using 2.7.x? e.g. 

/home/runner/work/M3/M3/vendor/bundle/ruby/2.7.0/gems/json-schema-2.8.1/lib/json-schema/schema/reader.rb:121: warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open
bastelfreak commented 2 years ago

@os6sense we do plan to fix those in the future when we've some time. I also haven't reviewed the remaining PRs yet. Feel free to take a look as well or zo provide a new PR that fixes this. every contribution is welcome!

bastelfreak commented 2 years ago

@ekohl are you fine with merging this for now and update it later? Or can you submit your code as a PR?