search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 241 forks source link

Call URI.open directly / Drop Ruby 2.4 support #462

Closed bastelfreak closed 2 years ago

bastelfreak commented 2 years ago

Removes warning: "calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open"

bastelfreak commented 2 years ago

Rebase of https://github.com/voxpupuli/json-schema/pull/459

codecov[bot] commented 2 years ago

Codecov Report

Merging #462 (6626f40) into master (079c432) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files          74       74           
  Lines        1581     1581           
=======================================
  Hits         1419     1419           
  Misses        162      162
Impacted Files Coverage Δ
lib/json-schema/schema/reader.rb 98.07% <100.00%> (ø)
lib/json-schema/validator.rb 84.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 079c432...6626f40. Read the comment docs.

bastelfreak commented 2 years ago

comment from the second commit:

The codechange is required to work properly on newer Ruby versions, but
breaks Ruby 2.4. Since Ruby 2.4 is EoL since a long time it's fine to
drop support for it. This also makes it easier to add Ruby 3 support
later.