voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 241 forks source link

fix more rubocop violations #490

Closed bastelfreak closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.98% // Head: 89.98% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (890de37) compared to base (3f1e2fe). Patch coverage: 75.00% of modified lines in pull request are covered.

:exclamation: Current head 890de37 differs from pull request most recent head cb1699d. Consider uploading reports for the commit cb1699d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #490 +/- ## ========================================== - Coverage 89.98% 89.98% -0.01% ========================================== Files 76 76 Lines 1578 1577 -1 ========================================== - Hits 1420 1419 -1 Misses 158 158 ``` | [Impacted Files](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli) | Coverage Δ | | |---|---|---| | [lib/json-schema/attributes/ref.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL2F0dHJpYnV0ZXMvcmVmLnJi) | `80.55% <0.00%> (ø)` | | | [lib/json-schema/util/uuid.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL3V0aWwvdXVpZC5yYg==) | `47.40% <50.00%> (ø)` | | | [lib/json-schema/validator.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL3ZhbGlkYXRvci5yYg==) | `85.06% <50.00%> (ø)` | | | [lib/json-schema/attribute.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL2F0dHJpYnV0ZS5yYg==) | `100.00% <100.00%> (ø)` | | | [lib/json-schema/attributes/additionalproperties.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL2F0dHJpYnV0ZXMvYWRkaXRpb25hbHByb3BlcnRpZXMucmI=) | `100.00% <100.00%> (ø)` | | | [lib/json-schema/attributes/format.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL2F0dHJpYnV0ZXMvZm9ybWF0LnJi) | `100.00% <100.00%> (ø)` | | | [lib/json-schema/schema.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL3NjaGVtYS5yYg==) | `96.96% <100.00%> (ø)` | | | [lib/json-schema/util/array\_set.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL3V0aWwvYXJyYXlfc2V0LnJi) | `100.00% <100.00%> (ø)` | | | [lib/json-schema/util/uri.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL3V0aWwvdXJpLnJi) | `100.00% <100.00%> (ø)` | | | [lib/json-schema/validators/draft1.rb](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL3ZhbGlkYXRvcnMvZHJhZnQxLnJi) | `100.00% <100.00%> (ø)` | | | ... and [9 more](https://codecov.io/gh/voxpupuli/json-schema/pull/490?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

b4ldr commented 1 year ago

LGTM and seems like just style changes but not too familiar with this repo