search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 241 forks source link

[472] - Fix for Accept nullable parameter #498

Open jahir-husain opened 11 months ago

jahir-husain commented 11 months ago

Fix for issue #472

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% :tada:

Comparison is base (76ea712) 90.08% compared to head (f0051ff) 90.11%.

:exclamation: Current head f0051ff differs from pull request most recent head 3c7f264. Consider uploading reports for the commit 3c7f264 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #498 +/- ## ========================================== + Coverage 90.08% 90.11% +0.03% ========================================== Files 76 76 Lines 1584 1589 +5 ========================================== + Hits 1427 1432 +5 Misses 157 157 ``` | [Files Changed](https://app.codecov.io/gh/voxpupuli/json-schema/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli) | Coverage Δ | | |---|---|---| | [lib/json-schema/attribute.rb](https://app.codecov.io/gh/voxpupuli/json-schema/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL2F0dHJpYnV0ZS5yYg==) | `100.00% <100.00%> (ø)` | | | [lib/json-schema/attributes/type.rb](https://app.codecov.io/gh/voxpupuli/json-schema/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL2F0dHJpYnV0ZXMvdHlwZS5yYg==) | `100.00% <100.00%> (ø)` | | | [lib/json-schema/attributes/type\_v4.rb](https://app.codecov.io/gh/voxpupuli/json-schema/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=voxpupuli#diff-bGliL2pzb24tc2NoZW1hL2F0dHJpYnV0ZXMvdHlwZV92NC5yYg==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jahir-husain commented 11 months ago

@bastelfreak - Can you review this, Please.

bastelfreak commented 11 months ago

@jahir-husain can you please rebase against our latest master branch and squash the commits down?

bastelfreak commented 9 months ago

@jahir-husain can you please take a look at the comment and rebase against our latest master (so we get rid of the merge commits).

bastelfreak commented 9 months ago

@jahir-husain please rebase instead of doing a merge.

kntmrkm commented 2 months ago

any update?

bastelfreak commented 2 months ago

@kntmrkm this PR needs a rebase. If you want you can checkout the code locally, rebase it against our Head and then submit a new PR.

notEthan commented 2 months ago

nullable has never been a JSON Schema keyword. It used to be a keyword of OpenAPI's schema, though isn't anymore. I don't know that a JSON Schema validator should be validating keywords that aren't part of JSON Schema.