search

voxpupuli / json-schema

Ruby JSON Schema Validator
MIT License
1.52k stars 241 forks source link

Support frozen string literals #507

Closed mostlyobvious closed 3 months ago

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2cc181b) 90.08% compared to head (3dd3e77) 90.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #507 +/- ## ======================================= Coverage 90.08% 90.08% ======================================= Files 76 76 Lines 1584 1584 ======================================= Hits 1427 1427 Misses 157 157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mostlyobvious commented 5 months ago

I'd prefer to separate out the CI changes. It's probably better to drop Ruby 2.5 (and 2.6). I'd keep 2.7 for a bit longer, even though it's already EOL.

I'd prefer to not make any CI changes either. They were unfortunately necessary. While I share the sentiment to drop older EOL Ruby versions, I do not see much recent activity around it [#478].

I also do not see how those Ruby CI changes you eventually want are blocking the improvement of running with frozen string literals enabled. There is no conflict in making Ruby 2.5 matrix a bit better with updated-and-fixed Rubygems, even if it is going to be dropped soon. And it is something already done.