search

voxpupuli / librarian-puppet

MIT License
95 stars 38 forks source link

Install fails when referenced module uses r10k format Puppetfile #43

Open fatmcgav opened 7 years ago

fatmcgav commented 7 years ago

As observed when attempting to add https://github.com/SugarFactory/puppet-beats to an existing Puppetfile for installation via Librarian-Puppet, the install fails with:

Puppetfile:7:in run': undefined methodmoduledir' for # (NoMethodError)

Full stack trace available here: https://gist.github.com/fatmcgav/f0f86f6664c8c4e75366a33e3f625681

Would be useful if Librarian-Puppet either supported or ignored any fields specific to r10k...

Yggdrasil commented 6 years ago

@fatmcgav Could you perhaps show which part of your Puppetfile causes this to happen? I think I'm running into a similar problem.

fatmcgav commented 6 years ago

Yeh, in the end we forked the 'puppet-beats' module and modified the Puppetfile - https://github.com/weareact/puppet-beats/commit/bc2267a51026d05e2d3242c0c02baf9d5a8aa250