Closed neomilium closed 3 years ago
Merging #242 (63bdcc2) into master (8808b35) will increase coverage by
0.57%
. The diff coverage is100.00%
.:exclamation: Current head 63bdcc2 differs from pull request most recent head 3ddcd7c. Consider uploading reports for the commit 3ddcd7c to get more accurate results
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 84.22% 84.80% +0.57%
==========================================
Files 30 30
Lines 894 908 +14
==========================================
+ Hits 753 770 +17
+ Misses 141 138 -3
Impacted Files | Coverage Δ | |
---|---|---|
features/step_definitions/git_steps.rb | 95.83% <100.00%> (+0.59%) |
:arrow_up: |
lib/modulesync/repository.rb | 93.06% <100.00%> (+3.17%) |
:arrow_up: |
spec/helpers/faker/puppet_module_remote_repo.rb | 87.20% <100.00%> (+0.95%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8808b35...3ddcd7c. Read the comment docs.
This PR implements scenario where the
.sync.yml
file is changed between twomsync update
runs as described in #192.The test works without code modifications and I think this #192 issue was fixed during refactoring.
IMHO, we could mark #192 as fixed after this PR will be merged.