search

voxpupuli / modulesync

Synchronize common files across your Git repositories.
Apache License 2.0
104 stars 48 forks source link

Fix rubocop offences and add linter to CI #243

Closed neomilium closed 3 years ago

neomilium commented 3 years ago

Fixes #237

codecov[bot] commented 3 years ago

Codecov Report

Merging #243 (dee929d) into master (6aee34b) will decrease coverage by 0.03%. The diff coverage is 87.50%.

:exclamation: Current head dee929d differs from pull request most recent head d27bcc9. Consider uploading reports for the commit d27bcc9 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   84.80%   84.76%   -0.04%     
==========================================
  Files          30       30              
  Lines         908      906       -2     
==========================================
- Hits          770      768       -2     
  Misses        138      138
Impacted Files Coverage Δ
lib/modulesync/cli.rb 100.00% <ø> (ø)
lib/modulesync/git_service.rb 54.34% <0.00%> (ø)
lib/modulesync/git_service/factory.rb 90.90% <ø> (ø)
lib/modulesync/settings.rb 100.00% <ø> (ø)
lib/modulesync.rb 98.98% <100.00%> (-0.02%) :arrow_down:
lib/modulesync/git_service/base.rb 90.00% <100.00%> (ø)
lib/modulesync/git_service/github.rb 100.00% <100.00%> (ø)
lib/modulesync/git_service/gitlab.rb 100.00% <100.00%> (ø)
lib/modulesync/hook.rb 100.00% <100.00%> (ø)
lib/modulesync/renderer.rb 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6aee34b...d27bcc9. Read the comment docs.

ekohl commented 3 years ago

Could you introduce an explicit error to see if the formatter works?

ekohl commented 3 years ago

This means you do end up running Rubocop for every Ruby version. The reporting is then very duplicate. Have you considered a separate test it depends on? https://github.com/voxpupuli/puppet-example/blob/master/.github/workflows/ci.yml can be a good example (though much more complex than you actually need here).