ekohl commented 2 years ago

In Ruby 3.1 using trim_mode must be passed as a keyword argument or a deprecation warning is shown. However, that is only possible on Ruby 2.7 or newer.

ekohl commented 2 years ago

The Rubocop failure is unrelated, but I think we should disable https://docs.rubocop.org/rubocop/cops_style.html#stylefetchenvvar because IMHO it's a bad case. Especially since this gem is already handling it anyway.

codecov[bot] commented 2 years ago

Codecov Report

Merging #252 (8aafb27) into master (39863fc) will decrease coverage by 0.06%. The diff coverage is 75.00%.

:exclamation: Current head 8aafb27 differs from pull request most recent head f29318f. Consider uploading reports for the commit f29318f to get more accurate results

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   87.20%   87.14%   -0.07%     
==========================================
  Files          30       30              
  Lines        1016     1019       +3     
==========================================
+ Hits          886      888       +2     
- Misses        130      131       +1

Impacted Files	Coverage Δ
lib/modulesync/renderer.rb	`96.29% <75.00%> (-3.71%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39863fc...f29318f. Read the comment docs.

voxpupuli / modulesync

Handle Ruby 3.1 ERB trim_mode deprecation #252

Codecov Report