search

voxpupuli / modulesync

Synchronize common files across your Git repositories.
Apache License 2.0
104 stars 48 forks source link

create a script/extension to automatically create PRs #80

Closed bastelfreak closed 4 years ago

bastelfreak commented 8 years ago

I think the title describes it very good. also @bbriggs said he is interested in implementing this

bbriggs commented 8 years ago

Unless anyone has objections, I plan to just extend the existing gem in Ruby as opposed to adding a new script. The feature will be triggered with a command line switch.

bastelfreak commented 8 years ago

@danzilio do you have any suggestions here?

danzilio commented 8 years ago

Sounds good to me. Honestly, I'd like to see a plugin system here (for example, it would be nice to support submitting PRs for GitLab and Stash as well) but that's a much bigger task. Let's see what this looks like and go from there.

bbriggs commented 8 years ago

So maybe a modulesync-github-pr gem, then?

bbriggs commented 8 years ago

And then have the modulesync-*-pr gems provide a common API to modulesync so it can choose the appropriate gem/plugin to call when --auto-pr is enabled?

danzilio commented 8 years ago

@bbriggs Exactly! I'd loooove to see that. But, right now, the API in modulesync isn't particularly robust. It would definitely be an undertaking. Although, maybe this is a good place to start...

rnelson0 commented 8 years ago

modulesync-pr-* would probably be better for sorting, tab completion, etc,

Rob Nelson rnelson0@gmail.com

bbriggs commented 8 years ago

I guess now I get to write my first gem. Yay Ruby!

sean797 commented 7 years ago

@bbriggs did you ever make a start on this ?

bbriggs commented 7 years ago

:(

bbriggs commented 7 years ago

In my heart I really want to but realistically I don't think I'll be able to get to this.

timhughes commented 7 years ago

not the most elegant code but here is what I use for gitlab https://gist.github.com/timhughes/80928f02baf7ee5c52180b16f0a2ba0b

ekohl commented 7 years ago

Personally I use the following:

rm -rf modules
bundle exec msync update --noop
# Ensure all modules are good to go - hopefully nothing was changed in files but not .sync.yml
MESSAGE="..."
for mod in modules/* ; do
    echo "Handling $mod"
    git commit -a -m "$MESSAGE" && git push $(whoami) HEAD -u && hub pull-request -m "$MESSAGE"
done

Personally I like the control over msync doing the commits but in general it's clear. https://hub.github.com/ is a great tool and I'd be a lot less efficient at using github if I had to use the UI to do PRs.

bittner commented 6 years ago

Any hope we'll see a GitLab MR feature in modulesync anytime soon?

bittner commented 6 years ago

The GitLab integration module of choice would probably be https://narkoz.github.io/gitlab/.

bittner commented 4 years ago

Just a heads-up to make interested parties understand how we at @vshn use ModuleSync:

Thanks everyone here for this great tool that proves to be so useful! :100: :rocket: :bowing_man: :bowing_woman:

BTW, can we now close this issue? Creating GitHub PRs and GitLab MRs is now possible.

bastelfreak commented 4 years ago

thanks for the reminder. I agree that we should close this issue