search

voxpupuli / modulesync_config

configuration for our module sync
Apache License 2.0
10 stars 71 forks source link

Remove tight coupling to gha-puppet in gha workflow templates #887

Closed h-haaks closed 5 months ago

h-haaks commented 6 months ago

When adding new inputs to files in https://github.com/voxpupuli/gha-puppet/tree/v2/.github/workflows we always have to make changes to https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.github/workflows/ci.yml.erb to reflect this.

By adding a 'with' key to .sync.yml and checking @configs['with'] in ci.yml.erb we could remove this tight copling.

Sample .sync.yml

.github/workflows/ci.yml:
  with:
    beaker_hosts: 'host1:shard.ma;host2:slave,router.a'
    beaker_facter: 'mongodb_repo_version:MongoDB:4.4,5.0,6.0,7.0'
h-haaks commented 6 months ago

To not break existing modules we have to implement this in 3 stages: 1: support 'with' 2: use 'with' in alle modules that use inputs 3: cleanup ci.yml.erb