search

voxpupuli / onceover

Your gateway drug to automated infrastructure testing with Puppet
Apache License 2.0
142 stars 45 forks source link

Support spec files selection before running tests #262

Closed neomilium closed 4 years ago

neomilium commented 4 years ago

This PR is related to #261

Before this PR, using onceover when you have other traditional rspec spec tests may be a problem if you:

This PR provides a way to only include selected files from spec/ directory, before running onceover.

neomilium commented 4 years ago

This PR is fully functional but need a review to find a better option name, if relevant.

If @dylanratcliffe is interested in merging this PR, I'll improve README.md file to document the new config entry.

neomilium commented 4 years ago

Please note that travis checks failed due to a ruby 2.5 method usage. If you want to support obsolete ruby version (2.3 is EOL since 1 year and 2.4 will be at the end of this month), I can improve the PR.

neomilium commented 4 years ago

@dylanratcliffe Have you looked to this PR?

neomilium commented 4 years ago

@dylanratcliffe Hello, what about this PR?

neomilium commented 4 years ago

@dylanratcliffe I rebased my patch on top of your master.

dylanratcliffe commented 4 years ago

Hey sorry I've left this for so long. Yeah we need 2.4 to ensure Puppet 5 compatibility as @smortex mentioned. I like the functionality, but can I please get the option documented in the README? I'm happy to merge once that's done and the tests pass. I think it's another transient Appveyor error so I'll kick that off again now

neomilium commented 4 years ago

@dylanratcliffe Done!

smortex commented 4 years ago

CI failure is unrelated to the change (transient failure).

dylanratcliffe commented 4 years ago

I'm re-running the failed tests and once they're green I'll merge

dylanratcliffe commented 4 years ago

Releases in: https://github.com/dylanratcliffe/onceover/releases/tag/v3.18.0