search

voxpupuli / onceover

Your gateway drug to automated infrastructure testing with Puppet
141 stars 45 forks source link

undefined method name_to_principal when using DSC #269

Closed dylanratcliffe closed 4 years ago

dylanratcliffe commented 4 years ago

Slack Conversation with Pete

Hi everyone. I've been running through Dylan's onceover with a customer recently and testing is very smooth with all of their Linux systems. However for Windows catalogs where they are using the win_dsc module, we get the following error:

undefined method `name_to_principal' for Puppet::Util::Windows::SID:Module

Dylan Ratcliffe 12 months ago

Got a bit of work done on it tonight but I’m not much further into working out what’s going on. It’s almost definitely an artefact of this process: It transforms the server catalog produced by the compiler into a RAL (agent) catalog. That process triggers all of the validation, munge, provider selection that normally occurs on the agent (https://tickets.puppetlabs.com/browse/PUP-9786). It will almost definitely be a situation that needs some mocking or monkeypatching but I can’t work out exactly how

Dylan Ratcliffe 12 months ago

Okay I think I’m basically going to have to replicate the method used in rspec-puppet for the other windows mocking stuff. Will work on this on the plane today if I can

dylanratcliffe commented 4 years ago

Working on this now, needs more mocking around windows ADSI than rspec-puppet currently provides. I'lll attempt to create a PR upstream to rspec-puppet if I can add the required patches