search

voxpupuli / onceover

Your gateway drug to automated infrastructure testing with Puppet
141 stars 45 forks source link

Allow Facter 4 #294

Closed genebean closed 3 years ago

genebean commented 3 years ago

It seems safe to remove the Facter restriction now.

genebean commented 3 years ago

This is intentionally behind master because the changes post-3.18.1 have broken my use of Onceover. I based the PR on the 3.18.1 tag.

neomilium commented 3 years ago

This is intentionally behind master because the changes post-3.18.1 have broken my use of Onceover. I based the PR on the 3.18.1 tag.

(Some) Changes post-3.18.1 break my setup too. Could you give more explanations about this? (probably in a dedicated issue).

Maybe the patch I provided in #292 could fix your setup as it does for me.

genebean commented 3 years ago

Maybe the patch I provided in #292 could fix your setup as it does for me.

Yep... that was it. We include a module in site.pp that fails catalog compilation if certain facts are faked and it seems that Onceover is not setting the certname to that of the factset being tested so it blew up.

genebean commented 3 years ago

289 combined with the manifest thing were my stumbling block