search

voxpupuli / onceover

Your gateway drug to automated infrastructure testing with Puppet
Apache License 2.0
142 stars 45 forks source link

Pin pathspec #304

Closed alexjfisher closed 6 months ago

alexjfisher commented 3 years ago

puppetlabs_spec_helper 2.16.0 just dropped this pin and pathspec 1.0.0 depends on ruby 2.6.

Pinning pathspec here isn't ideal, but since bundler ignores the ruby version requirement set on a gem and only the version of ruby that ships with Puppet 7 supports pathspec 1.0.0 this is probably the most user friendly option.

dylanratcliffe commented 3 years ago

@DavidS Are you able to weigh in here as to why we should do this as per our conversation in slack? I don't totally understand why we wouldn't do it?

dylanratcliffe commented 6 months ago

I can't for the life of me remember why we needed to do this be everything seems to be working well in tests and in my environment in much newer version of everything so I'm going to assume it's solved