voxpupuli / onceover

Your gateway drug to automated infrastructure testing with Puppet
Apache License 2.0
142 stars 45 forks source link

Adapted for Facter 4 factsets #308

Closed genebean closed 3 years ago

genebean commented 3 years ago

The facts function was updated to understand that the top level key 'values' may not exist. A two new factsets were added under spec to validate things work with both a Facter 4 and pre-Facter 4 factset is present. Additionally, the list of nodes in the caching control repo was sorted.

In addition to changes directly related to this issue, fixes required by the current version of Rubocop were also applied.

Fixes #307

genebean commented 3 years ago

I am using this in our internal control repo and it has unbroken my CI runs that include old and new factsets