search

voxpupuli / onceover

Your gateway drug to automated infrastructure testing with Puppet
Apache License 2.0
142 stars 45 forks source link

rspec-puppet v4.0 breaks onceover #330

Open stephenCSE opened 11 months ago

stephenCSE commented 11 months ago

The rpec-puppet option 'parser' is no longer valid. The option is set the template spec_helper.rb.erb This causes onceover to break on systems that use the default pdk Gemfile.

https://github.com/dylanratcliffe/onceover/blob/cf42f96c2a6df6c92fc682120de3848a8ec733de/templates/spec_helper.rb.erb#L22

workaround: Add the following to Gemfile gem "rspec-puppet",'< 4.0.0', require: false

ChrLau commented 10 months ago

Same for trusted_server_facts. That got remove starting with Puppet 6.x. https://github.com/dylanratcliffe/onceover/blob/cf42f96c2a6df6c92fc682120de3848a8ec733de/templates/spec_helper.rb.erb#L26

And to potentially make Google pick up this issue, we see the following error messages in our Pipeline:

Failure/Error: c.parser                = 'future'
NoMethodError:
  undefined method `parser=' for #<RSpec::Core::Configuration:0x000055eba0546078>
Failure/Error: c.trusted_server_facts  = true
NoMethodError:
  undefined method `trusted_server_facts=' for #<RSpec::Core::Configuration:0x000055f50b9fe7e0>