search

voxpupuli / onceover

Your gateway drug to automated infrastructure testing with Puppet
Apache License 2.0
142 stars 45 forks source link

Fix compatibility with rspec-puppet 4+ #331

Closed smortex closed 6 months ago

smortex commented 11 months ago

These settings where used for compatibility with Puppet 7.10 and older (Puppet 7.10 was released more than 2 years ago). rspec-puppet 4 removed them: https://github.com/puppetlabs/rspec-puppet/pull/73

In order to avoid this kind of accident in the future, add an upper bound on the rspec-puppet dependency. Version 5.0.0 is also working with this change, so accept anything before 6.0.0.

smortex commented 11 months ago

CI is still failing because it depends on this to be merged: https://github.com/dylanratcliffe/puppet_controlrepo/pull/21

dylanratcliffe commented 6 months ago

Thanks for this @smortex! I ended up fixing this in a larger upgrade effort but thanks for the tips