search

voxpupuli / puppet-archive

Compressed archive file download and extraction with native types/providers for Windows and Unix
https://forge.puppet.com/puppet/archive
Apache License 2.0
59 stars 176 forks source link

Pass over credentials in archive::artifactory #433

Closed jramosf closed 3 years ago

jramosf commented 3 years ago

This change allows passing optional credentials to the archive resource from archive::artifactory.

jramosf commented 3 years ago

Hello @kenyon ,

You added the needs-tests label but I see #430 is already testing the password functionality of archive, and this is just passing over the parameters to that same function.

Cheers,

Rwwn commented 3 years ago

This doesn't work for me because the artifactory_checksum function also requires separate username/password authentication, which isn't covered in this PR. Providing the username and password still results in a forbidden error.