search

voxpupuli / puppet-archive

Compressed archive file download and extraction with native types/providers for Windows and Unix
https://forge.puppet.com/puppet/archive
Apache License 2.0
59 stars 176 forks source link

Produce a better error for the puppet downloader when file not found #434

Closed hajee closed 3 years ago

hajee commented 3 years ago

Newer versions of Puppet raise the error Puppet::HTTP::RouteError when the file is not found. This resulted not only in a misleading error but also an error without the original url.

This commit changes this. It catches the error and produces an error with the url in it. Unfortunately, the original misleading error is still produces, so we try to elaborate a bit in the error we produce.

hajee commented 3 years ago

Is there an ETA when there is time to look at this PR?

kenyon commented 3 years ago

Is there an ETA when there is time to look at this PR?

No, just when one of us @voxpupuli volunteers gets around to it. :smile:

The change seems fine to me, but I don't use this module.

bastelfreak commented 3 years ago

thanks for the PR!