voxpupuli / puppet-archive

Compressed archive file download and extraction with native types/providers for Windows and Unix
https://forge.puppet.com/puppet/archive
Apache License 2.0
59 stars 176 forks source link

Revert "Support for cacert_file param on archive resource" #440

Closed bastelfreak closed 3 years ago

bastelfreak commented 3 years ago

Reverts voxpupuli/puppet-archive#422

bastelfreak commented 3 years ago

As you can see in https://github.com/voxpupuli/puppet-archive/pull/439, master fails since the merge of https://github.com/voxpupuli/puppet-archive/pull/430. The thing is that 430 introduced new tests. So I guess one of the three PRs broke it but that wasn't detected because tests were missing:

bastelfreak commented 3 years ago

tests are green again, so I guess it's safe to say that this code broke it