voxpupuli / puppet-archive

Compressed archive file download and extraction with native types/providers for Windows and Unix
https://forge.puppet.com/puppet/archive
Apache License 2.0
60 stars 178 forks source link

Fix Could not set 'present' on ensure: wrong number of arguments (given 1, expected 0) #443

Closed jeffmccune closed 3 years ago

jeffmccune commented 3 years ago

Pull Request (PR) description

Without this patch a mysterious exception is thrown when the checksum does not match. This is a problem because it's unclear the problem is related to the checksum.

This patch fixes the problem by returning the correct error when the checksum doesn't match.

This Pull Request (PR) fixes the following issues

Wrapped exception:
wrong number of arguments (given 1, expected 0)
/opt/puppetlabs/puppet/cache/lib/puppet/provider/archive/ruby.rb:86:in `destroy'
/opt/puppetlabs/puppet/cache/lib/puppet/provider/archive/ruby.rb:197:in `transfer_download'
/opt/puppetlabs/puppet/cache/lib/puppet/provider/archive/ruby.rb:81:in `create'
/opt/puppetlabs/puppet/cache/lib/puppet/type/archive.rb:13:in `block (3 levels) in <top (required)>'
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/property.rb:490:in `set'
...
Error:
/Stage[main]/Profile::Consul::Consultemplate/Archive[/usr/local/bin/consul-template]/ensure:
change from 'absent' to 'present' failed: Could not set 'present' on
ensure: wrong number of arguments (given 1, expected 0) (file:
/etc/puppetlabs/code/environments/jeff/site-modules/profile/manifests/consul/consultemplate.pp,
line: 6)