search

voxpupuli / puppet-archive

Compressed archive file download and extraction with native types/providers for Windows and Unix
https://forge.puppet.com/puppet/archive
Apache License 2.0
59 stars 176 forks source link

ruby provider: ensure cleanup happens #474

Closed pillarsdotnet closed 1 year ago

pillarsdotnet commented 1 year ago

Pull Request (PR) description

Ensures that tempfile used for downloading gets deleted. Ensures that the cleanup param is honored.

This Pull Request (PR) fixes the following issues

Fixes #328

bastelfreak commented 1 year ago

Hi @pillarsdotnet, thanks for the PR. can you please rebase against our latest master branch?

pillarsdotnet commented 1 year ago

Rebased.

pillarsdotnet commented 1 year ago

@bastelfreak -- Would you please review?

kenyon commented 1 year ago

rubocop errors https://github.com/voxpupuli/puppet-archive/actions/runs/3643129527/jobs/6151017200

pillarsdotnet commented 1 year ago

@kenyon -- Thanks for fixes.