search

voxpupuli / puppet-augeas

Helper for using augeas with puppet
Apache License 2.0
44 stars 82 forks source link

Drop support for Puppet 4, 5, 6 (EOL) #101

Closed smortex closed 2 months ago

smortex commented 3 months ago

Also include:

smortex commented 3 months ago

Interesting, in facterdb, Archlinux (and a bunch of other OS) does not have a puppetversion fact.

jhoblitt commented 3 months ago

I'd rather the individual PRs aggregated here are merged separately so they appear in the change-log.

kenyon commented 3 months ago

@jhoblitt they'll all appear in the changelog when closed, regardless of how they are merged.

jhoblitt commented 3 months ago

@jhoblitt they'll all appear in the changelog when closed, regardless of how they are merged.

Closed but unmerged PRs do not appear in the changelog.

kenyon commented 3 months ago

@jhoblitt they'll all appear in the changelog when closed, regardless of how they are merged.

Closed but unmerged PRs do not appear in the changelog.

When this PR is merged, the included ones will also be closed as merged.

kenyon commented 3 months ago

There is a lot going on this PR that I feel would be better merged as isolated PRs that appear in the changelog. Also, some of the commits in this branch have a lot going on in them that isn't reflected in the commit messages. E.g. f6974ed

AFAICT, in that commit, all of the deleted code was only applicable to EOL versions of Puppet, where Augeas was not included in the all-in-one packages like we have now.

smortex commented 3 months ago

The PR title here also won't be very helpful in the changelog. What versions of puppet is support being dropped for?

:+1: Fixed, thanks!

When this PR is merged, the included ones will also be closed as merged.

That's correct, when all commits in a PR are merged, the PR is marked as merged and GitHub ChangeLog Generator include it as expected.

AFAICT, in that commit, all of the deleted code was only applicable to EOL versions of Puppet, where Augeas was not included in the all-in-one packages like we have now.

Correct, and we also discover that the legacy code was used on some platforms because they do not ship with puppetversion?!

jhoblitt commented 2 months ago

Could we either accept the arch failure and merge this or remove arch from this PR? We need to get a forge release out.

smortex commented 2 months ago

Could we either accept the arch failure and merge this or remove arch from this PR? We need to get a forge release out.

@bastelfreak you are my Arch referent :-D What do you think we should do?

bastelfreak commented 2 months ago

The Arch Linux failure was an actual bug. the puppet package didn't depend on ruby-augeas. I fixed the package upstream.