Refactoring - Githubissues

voxpupuli / puppet-augeas

Helper for using augeas with puppet

Apache License 2.0

43 stars 82 forks source link

Refactoring #2

Closed vurbia closed 11 years ago

vurbia commented 13 years ago

Small refactoring to:

Break files to contain only one class
Make regexes case-insensitive

Any comments welcome

athak commented 13 years ago

Hi, sorry for the delay, I never saw your comments on the pull request. The reasoning behind the refactoring was to keep the code DRY and comply with the Style Guide from Puppetlabs.

Cheers, Atha

raphink commented 11 years ago

Thank you for this PR. Since it was made from a master branch you kept pushing to (also our fault for not reviewing it earlier), it is hard to review now. Could you please make feature branches and PRs per feature?