search

voxpupuli / puppet-augeas

Helper for using augeas with puppet
Apache License 2.0
43 stars 82 forks source link

Better detection of ruby version #24

Closed phemmer closed 11 years ago

phemmer commented 11 years ago

This changes the way the module determines the name of the libaugeas-ruby package on debian.

The previous method relied upon hard-coded release names. Aside from the fact that this requires the module to keep track of every single release name available, it also doesn't consider the possibility that ruby has been upgraded.

The solution is to use the rubyversion fact which is already provided and contains the version of ruby that puppet itself is running under.

phemmer commented 11 years ago

I'm guessing the travis build is failing because it's faking the distribution version and looking for a specific ruby package to come back rather than faking the rubyversion fact.

raphink commented 11 years ago

I like that! Could you adjust the specs as well please?

raphink commented 11 years ago

@phemmer: Yes. You could fake the rubyversion fact in the spec instead.

raphink commented 11 years ago

https://github.com/camptocamp/puppet-augeas/pull/25 adds the missing specs. I'll close this PR and I'll merge #25 instead, probably next week.