search

voxpupuli / puppet-augeas

Helper for using augeas with puppet
Apache License 2.0
44 stars 82 forks source link

Handle lense_dir based on $::rubysitedir. #67

Closed bzed closed 7 years ago

bzed commented 7 years ago

Fixes: #65

mcanevet commented 7 years ago

@bzed could you please fix unit tests? Tests are passing on master so there must be something weird in your PR that make them fail.

bzed commented 7 years ago

@mcanevet I gave it a short try, but I fail to understand why it fails. So please take it and fix it or leave it broken.

mcanevet commented 7 years ago

@bzed the unit tests failure definitely comes from your code. See my comments.

bzed commented 7 years ago

@mcanevet see my last comment. take it, fix it, or leave it broken. I don't have the time to bother with that mess call spec tests.

bzed commented 7 years ago

@mcanevet so whats your fix for #65 ?

mcanevet commented 7 years ago

@bzed I think your code would work. I just closed your PR because it breaks the unit tests (which is unacceptable) and you obviously don't want to fix that (even if it's trivial). If you don't have time "to bother with that mess call spec tests", then I can provide you the contact of our salesman. I'm sure he will be happy to provide you a quote so that we do it for you. :-)

bzed commented 7 years ago

@mcanevet well thanks, I can happily live with the broken spec tests - and with a fork. but I guess other users might be happy if they could just keep using your module.

raphink commented 7 years ago

@bzed having tests that pass is a common requirement for all serious open-source projects. In the current case, it really shouldn't be too hard to fix, especially as everything is already implemented and the tests pass on the master branch.

We understand other users might want to use this patch (although we don't) but we are not willing to maintain code that is untested, and even less code that breaks code that we need (even if it fixes another issue). If you need support on how to fix the tests, I'm sure you can find it on many IRC/slack Puppet channels, and we might even help you fix them if you ask, but we won't merge a PR that doesn't pass existing tests.