Resolve puppet-lint - Githubissues

voxpupuli / puppet-augeas

Helper for using augeas with puppet

Apache License 2.0

44 stars 82 forks source link

Resolve puppet-lint #81

Closed jcpunk closed 3 years ago

jcpunk commented 3 years ago

This cleans up a few notices reported by puppet-lint

raphink commented 3 years ago

Thanks. Unfortunately, this breaks the spec tests and I don't see why.

jcpunk commented 3 years ago

It looks like the spec tests are using the 'legacy' facts and puppet-lint updated them to the new structured ones.

raphink commented 3 years ago

Yes. I had a quick look and I couldn't fix the new facts for some reason.

jcpunk commented 3 years ago

I've reverted the 'legacy facts' bits but left the seed values in the spec files. In theory if I ever figure out what is wrong I'll revisit the legacy fact fixes. But for now this PR covers most of the lint issues.... if the tests pass.