voxpupuli / puppet-augeas

Helper for using augeas with puppet
Apache License 2.0
44 stars 82 forks source link

Remove hiera data as it's unused #83

Closed towo closed 3 years ago

towo commented 3 years ago

It gets automatically created when enrolling with PDK, but is entirely unnecessary. In fact, in only results in

Warning: /etc/puppetlabs/code/environments/production/modules/augeas/data/common.yaml: file does not contain a valid yaml hash

on every Puppet run.

This PR is analogous to puppetlabs/puppetlabs-augeas_core!25, which faced the same problem.

Pigueiras commented 3 years ago

I think this was an old problem of PDK, another option is to modify the common.yaml with (ref: https://github.com/puppetlabs/pdk-templates/pull/321/files):

--- {}
smortex commented 3 years ago

We can also start using it :wink:

84 is just the tip of the iceberg… moving from params.pp to hiera can be a good addition IMHO.

towo commented 3 years ago

I'd argue to merge this in now just so that there's something that isn't throwing little errors, and if needed I'll look into migrating this module to Hiera-based data. Should be possible without a major bump as AFAIR the minimum required Puppet version (4.10) supports using Hiera as a module data backend.

raphink commented 3 years ago

I merged #84. Thanks for this.