Resolve puppetserver log warnings caused by undefined global variables

voxpupuli / puppet-augeasproviders

Alternative Augeas-based providers for Puppet

http://augeasproviders.com/

Apache License 2.0

63 stars 46 forks source link

Resolve puppetserver log warnings caused by undefined global variables #171

Closed walkleyn closed 2 years ago

walkleyn commented 2 years ago

Since puppet6, undefined global variables emit warnings in the puppetserver logs. Changing the value to a facts[''] value resolves it while still honouring the ability to pass in provider values via hieradata. Also addressing the deprecation of the validate_hash function. Related post regarding this found here: https://access.redhat.com/discussions/5672161#comment-now

ekohl commented 2 years ago

I see the backwards incompatible label is missing in this repo, but this should result in a major version bump.

I'll give other reviewers a chance to take a look, but I think this can be merged.