Fix GRUB_CMDLINE_LINUX_DEFAULT

voxpupuli / puppet-augeasproviders_grub

Augeas-based grub type and providers

Apache License 2.0

9 stars 33 forks source link

Fix GRUB_CMDLINE_LINUX_DEFAULT #14

Closed trevor-vaughan closed 8 years ago

trevor-vaughan commented 8 years ago

Ensure that any missing element is created before attemping to be modified. This prevents Augeas failures.
Copy GRUB_CMDLINE_LINUX to GRUB_CMDLINE_LINUX_DEFAULT if the latter does not exist.
Added Beaker tests to cover these two cases and allow for further practical expansion.

Fixes hercules-team/augeasproviders_grub#11

raphink commented 8 years ago

What is the added value of acceptance tests in this case?

trevor-vaughan commented 8 years ago

The main value of the acceptance tests is that it's testing the actuality of the system. If there is a change in Grub that would cause an issue in the future, then this can be caught early instead of discovering the issue in the field.

Also, frankly, we're finding acceptance tests to be more accurate and easier for most people to maintain than traditional spec tests.