voxpupuli / puppet-augeasproviders_grub

Augeas-based grub type and providers
Apache License 2.0
9 stars 33 forks source link

EFI support for all oses, not only fedora #27

Closed lapfrank closed 7 years ago

lapfrank commented 7 years ago

Hi,

Small change request. Issue #16 fixed the EFI support issue for Fedora, but not for every other system. Is there any way to fix the grub2.rb file line 151:

["/boot/grub/grub.cfg", "/boot/grub2/grub.cfg", "/boot/efi/EFI/fedora/grub.cfg"].each {|c|

to either use the "operatingsystem"variable instead of "fedora" or add other OSes to the list like RedHat and CentOS?

Thanks,

raphink commented 7 years ago

@trevor-vaughan seems you have a fix for this, right?

trevor-vaughan commented 7 years ago

@raphink Yeah, PR forthcoming.

trevor-vaughan commented 7 years ago

@lapfrank Mind doing a code review on #28 to make sure it solves your issue sufficiently?