Grub2 grub_user fix - Githubissues

voxpupuli / puppet-augeasproviders_grub

Augeas-based grub type and providers

Apache License 2.0

9 stars 33 forks source link

Grub2 grub_user fix #32

Closed trevor-vaughan closed 6 years ago

trevor-vaughan commented 6 years ago

The user generation script was incorrectly outputting additional erronous information

coveralls commented 6 years ago

Coverage remained the same at 95.402% when pulling dbc070f01088b2e63e16a2878c4a17b38a29b17b on trevor-vaughan:grub2_user_fix into ce7389d77963a7afa9e86edc22c88e8ee96895c1 on hercules-team:master.

olifre commented 6 years ago

Also why include /boot/grub/grub.cfg since that is only grub not grub2?

Since that's what Ubuntu uses for Grub2 configuration. This removal, which was not documented in the commit message, has broken at least Ubuntu (maybe also Debian).

Grub1 would use menu.lst which is completely unrelated to the files looked for here.

See #36 for my fixup PR.